topic Re: New variant values for Strato button in Developer Q&A Forum

New variant values for Strato button

michal_zawislak — Thu, 20 Apr 2023 07:33:32 GMT

Hello,

With the recent release of @dynatrace/strato-components-preview version 0.92.1, there were introduced breaking changes to the Button component i.e. variant prop. The migration script replaced only part of the old values, thus I have to replace the rest manually.

How do the new values ("default", "emphasized", "accent") correspond to the old ones ('primary', 'secondary', 'minimal', 'critical')

Re: New variant values for Strato button

s_eilmsteiner — Fri, 24 Mar 2023 09:31:12 GMT

Hi,
the design system team replace every minimal with default and for the rest:
* primary -> default
* secondary -> emphasized
* critical -> accent

I would recommend to use the same approach.

Re: New variant values for Strato button

michal_zawislak — Fri, 24 Mar 2023 09:37:02 GMT

The transition you provided is a bit different from what the migration script (partly) did i.e.:

primary -> accent (and color "primary")
critical -> emphasized (and color "critical")

Shouldn't I trust the migration?

Re: New variant values for Strato button

s_eilmsteiner — Fri, 24 Mar 2023 09:44:52 GMT

You are right I just looked up the minimal -> default mapping, because this looked confusing.

Re: New variant values for Strato button

michal_zawislak — Fri, 24 Mar 2023 10:14:14 GMT

I'm sorry, but I'm not sure if I understood correctly. If I would follow the transition rules for the "variant" prop:

minimal -> default
primary -> accent (and color "primary")
secondary -> emphasized
critical -> emphasized (and color "critical")

Would it be correct? Could you please confirm (or not)?

Re: New variant values for Strato button

s_eilmsteiner — Fri, 24 Mar 2023 10:27:05 GMT

Hi,
I followed up on that again and yes I can confirm exactly that.